Add Roblox OAuth2 Provider for Laravel Socialite #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the Roblox OAuth2 Provider for Laravel Socialite. It includes the provider's installation and usage instructions in the README file as well as the implementation of the Provider class. It also updates the monorepo-builder.yml file to include a new reference to the Roblox provider repository.
atymic
requested changes
Apr 16, 2024
Removed the redundant 'additionalConfigKeys' method from the Provider class. Also, corrected the package name in composer.json from 'discord' to 'roblox'.
|
Fixed the comments |
lucasmichot
reviewed
Apr 16, 2024
| protected function getCodeFields($state = null) | ||
| { | ||
| return array_merge(parent::getCodeFields($state), [ | ||
| 'client_id' => $this->clientId, |
There was a problem hiding this comment.
Aren't these properties already set in the parent method?
atymic
approved these changes
Jun 8, 2024
|
Please PR to website https://github.com/SocialiteProviders/website |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the Roblox OAuth2 Provider for Laravel Socialite. It includes the provider's installation and usage instructions in the README file as well as the implementation of the Provider class. It also updates the monorepo-builder.yml file to include a new reference to the Roblox provider repository.