Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/set approvedScopes in User #206

Closed

Conversation

lsnider
Copy link
Contributor

@lsnider lsnider commented Jan 26, 2022

If laravel/socialite#572 gets merged, this PR brings the approved scopes to SocialiteProviders.

@lsnider
Copy link
Contributor Author

lsnider commented Jan 27, 2022

Now that the laravel/socialite#572 PR has been merged, this can too but we may need to address that this package supports "laravel/socialite": "~4.0 || ~5.0" where as laravel/socialite#572 was merged into the 5.x branch. Perhaps now is a good time to drop support for 4.x?

@stale
Copy link

stale bot commented Apr 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 9, 2022
@stale stale bot closed this Apr 16, 2022
@lsnider
Copy link
Contributor Author

lsnider commented Apr 21, 2022

Poke

@satezmedia
Copy link

satezmedia commented Mar 29, 2023

@atymic Would it be possible to reopen/merge this PR?

@bilfeldt
Copy link

bilfeldt commented Apr 5, 2024

Let us re-open this issue 👍 It is a better solution than the currently open (draft) PR #225 and is closes #224

Things that need to be addressed:

@atymic atymic reopened this Apr 29, 2024
@stale stale bot removed the stale label Apr 29, 2024
@atymic
Copy link
Member

atymic commented Apr 29, 2024

@bilfeldt Re-opened.

Maybe we should override the default method, see comment.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (82c9bda) to head (6dd81fc).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
- Coverage     53.94%   53.94%   -0.01%     
- Complexity       77       79       +2     
============================================
  Files            10       10              
  Lines           228      241      +13     
============================================
+ Hits            123      130       +7     
- Misses          105      111       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants