New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch from gitlab to github #723
Changes from 7 commits
659f728
285ee35
fb07c30
90bdff5
d557960
118bd17
cccb2c9
97a0a74
cf827f6
537b56b
17f9dc0
3e0a01b
65d2b7d
8a054d3
9e2f2f3
b1f02e4
e344cdc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
# For most projects, this workflow file will not need changing; you simply need | ||
# to commit it to your repository. | ||
# | ||
# You may wish to alter this file to override the set of languages analyzed, | ||
# or to provide custom queries or build logic. | ||
# | ||
# ******** NOTE ******** | ||
# We have attempted to detect the languages in your repository. Please check | ||
# the `language` matrix defined below to confirm you have the correct set of | ||
# supported CodeQL languages. | ||
# | ||
name: "CodeQL" | ||
|
||
on: | ||
push: | ||
branches: ["master"] | ||
pull_request: | ||
# The branches below must be a subset of the branches above | ||
branches: ["master"] | ||
schedule: | ||
- cron: "16 1 * * 5" | ||
|
||
concurrency: | ||
cancel-in-progress: true | ||
group: codeql-${{ github.ref }} | ||
|
||
jobs: | ||
analyze: | ||
name: Analyze | ||
runs-on: ubuntu-latest | ||
permissions: | ||
actions: read | ||
contents: read | ||
security-events: write | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
language: ["javascript"] | ||
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] | ||
# Learn more: | ||
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
# Initializes the CodeQL tools for scanning. | ||
- name: Initialize CodeQL | ||
uses: github/codeql-action/init@v1 | ||
with: | ||
languages: ${{ matrix.language }} | ||
# If you wish to specify custom queries, you can do so here or in a config file. | ||
# By default, queries listed here will override any specified in a config file. | ||
# Prefix the list here with "+" to use these queries and those in the config file. | ||
# queries: ./path/to/local/query, your-org/your-repo/queries@main | ||
|
||
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java). | ||
# If this step fails, then you should remove it and run the build manually (see below) | ||
- name: Autobuild | ||
uses: github/codeql-action/autobuild@v1 | ||
|
||
# ℹ️ Command-line programs to run using the OS shell. | ||
# 📚 https://git.io/JvXDl | ||
|
||
# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines | ||
# and modify them (or add more) to build your code if your project | ||
# uses a compiled language | ||
|
||
#- run: | | ||
# make bootstrap | ||
# make release | ||
|
||
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
name: Code quality | ||
|
||
on: [pull_request] | ||
|
||
concurrency: | ||
cancel-in-progress: true | ||
group: quality-${{ github.ref }} | ||
|
||
jobs: | ||
build: | ||
name: Build | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: '14.18.0' | ||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
run: echo "::set-output name=dir::$(yarn cache dir)" | ||
- name: Restore cache | ||
uses: actions/cache@v2 | ||
with: | ||
path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-yarn- | ||
- name: Install dependencies | ||
run: | | ||
yarn install --prefer-offline --frozen-lockfile | ||
- name: Build code | ||
run: | | ||
yarn build | ||
- name: Cache build | ||
uses: actions/cache@v2 | ||
with: | ||
path: ./* | ||
key: ${{ github.sha }} | ||
|
||
lint: | ||
name: Lint | ||
runs-on: ubuntu-latest | ||
needs: [build] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
repositories: | ||
[ | ||
"frontend", | ||
"alert-cli", | ||
"ingester", | ||
"ingester-es", | ||
"@shared/dila-resolver", | ||
"@socialgouv/cdtn-elasticsearch", | ||
"@shared/elasticsearch-document-adapter", | ||
"@socialgouv/cdtn-logger" | ||
] | ||
steps: | ||
- uses: actions/cache@v2 | ||
name: Restore build | ||
with: | ||
path: ./* | ||
key: ${{ github.sha }} | ||
- name: Lint ${{ matrix.repositories }} | ||
run: | | ||
yarn workspace ${{ matrix.repositories }} lint | ||
|
||
test: | ||
name: Test | ||
runs-on: ubuntu-latest | ||
needs: [ build ] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
repositories: | ||
[ | ||
"frontend", | ||
"alert-cli", | ||
"ingester", | ||
"ingester-es", | ||
"@shared/dila-resolver", | ||
"@socialgouv/cdtn-elasticsearch", | ||
"@shared/elasticsearch-document-adapter", | ||
"@socialgouv/cdtn-logger" | ||
] | ||
steps: | ||
- uses: actions/cache@v2 | ||
name: Restore build | ||
with: | ||
path: ./* | ||
key: ${{ github.sha }} | ||
- name: Test ${{ matrix.repositories }} | ||
run: | | ||
yarn workspace ${{ matrix.repositories }} test | ||
|
||
docker: | ||
name: Lint Dockerfile | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
- name: Lint Dockerfile | ||
uses: hadolint/hadolint-action@v1.6.0 | ||
with: | ||
failure-threshold: error | ||
recursive: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
name: Security vulnerability scanner | ||
|
||
on: | ||
push: | ||
branches: ["master"] | ||
|
||
concurrency: | ||
cancel-in-progress: true | ||
group: security-${{ github.ref }} | ||
|
||
jobs: | ||
register: | ||
name: Register images | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Register docker image for frontend | ||
uses: SocialGouv/actions/autodevops-build-register@local-cache-cdtn | ||
with: | ||
project: "cdtn-admin" | ||
imageName: cdtn-admin/cdtn-admin-frontend | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
dockerfile: "./targets/frontend/Dockerfile" | ||
dockercontext: "./targets/frontend/" | ||
|
||
trivy: | ||
name: Run trivy | ||
runs-on: ubuntu-18.04 | ||
needs: [register] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
images: ["cdtn-admin-frontend"] | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Build ${{ matrix.images }} from Dockerfile | ||
run: | | ||
docker build -t ghcr.io/socialgouv/cdtn-admin/${{ matrix.images }}:sha-${{ github.sha }} . | ||
- name: Run Trivy vulnerability scanner | ||
uses: aquasecurity/trivy-action@master | ||
with: | ||
image-ref: "ghcr.io/socialgouv/cdtn-admin/${{ matrix.images }}:sha-${{ github.sha }}" | ||
format: "table" | ||
ignore-unfixed: true | ||
vuln-type: "os,library" | ||
severity: "CRITICAL,HIGH" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Gitlab mirroring | ||
|
||
on: | ||
- push | ||
- delete | ||
|
||
jobs: | ||
mirror_gitlab: | ||
name: 🪞 Gitlab | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: SocialGouv/actions/mirror-gitlab@master | ||
with: | ||
project: SocialGouv/cdtn/cdtn-admin | ||
token: ${{ secrets.SOCIALGROOVYBOT_GITLAB_TOKEN }} |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,5 +23,8 @@ | |
"name": "cdtn-admin", | ||
"volta": { | ||
"node": "14.18.0" | ||
}, | ||
"engines": { | ||
"node": "v14.18.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sre sans ça la github action est en node 16. C'est la bonne approche ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ca permet de forcer la gh-action en 14 ? stylé ! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non, malheureusement. Ca permet de spécifier la version de node attendue par yarn. Pour la github workflow, on a dû utiliser l'action setup-nodes.
Cela me semble être la bonne approche, je ne vois pas comment préciser la version de node différement dans une action github. Et ça me semble logique car cela fait partie du test aussi. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ha ok, j'avais espéré que l'action exploite cette info dans le package.json 😅 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nb: il y a possibilité d'utiliser un .nvmrc actions/setup-node#338 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bien vu ! :) |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on pourrait faire une matrix ici dans le futur comme ça avec trivy en bas, ça va bien correspondre