Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch from gitlab to github #723

Merged
merged 17 commits into from Mar 8, 2022
75 changes: 75 additions & 0 deletions .github/workflows/codeql-analysis.yml
@@ -0,0 +1,75 @@
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"

on:
push:
branches: ["master"]
pull_request:
# The branches below must be a subset of the branches above
branches: ["master"]
schedule:
- cron: "16 1 * * 5"

concurrency:
cancel-in-progress: true
group: codeql-${{ github.ref }}

jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: false
matrix:
language: ["javascript"]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

steps:
- name: Checkout repository
uses: actions/checkout@v2

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
107 changes: 107 additions & 0 deletions .github/workflows/quality.yml
@@ -0,0 +1,107 @@
name: Code quality

on: [pull_request]

concurrency:
cancel-in-progress: true
group: quality-${{ github.ref }}

jobs:
build:
name: Build
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '14.18.0'
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Restore cache
uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Install dependencies
run: |
yarn install --prefer-offline --frozen-lockfile
- name: Build code
run: |
yarn build
- name: Cache build
uses: actions/cache@v2
with:
path: ./*
key: ${{ github.sha }}

lint:
name: Lint
runs-on: ubuntu-latest
needs: [build]
strategy:
fail-fast: false
matrix:
repositories:
[
"frontend",
"alert-cli",
"ingester",
"ingester-es",
"@shared/dila-resolver",
"@socialgouv/cdtn-elasticsearch",
"@shared/elasticsearch-document-adapter",
"@socialgouv/cdtn-logger"
]
steps:
- uses: actions/cache@v2
name: Restore build
with:
path: ./*
key: ${{ github.sha }}
- name: Lint ${{ matrix.repositories }}
run: |
yarn workspace ${{ matrix.repositories }} lint

test:
name: Test
runs-on: ubuntu-latest
needs: [ build ]
strategy:
fail-fast: false
matrix:
repositories:
[
"frontend",
"alert-cli",
"ingester",
"ingester-es",
"@shared/dila-resolver",
"@socialgouv/cdtn-elasticsearch",
"@shared/elasticsearch-document-adapter",
"@socialgouv/cdtn-logger"
]
steps:
- uses: actions/cache@v2
name: Restore build
with:
path: ./*
key: ${{ github.sha }}
- name: Test ${{ matrix.repositories }}
run: |
yarn workspace ${{ matrix.repositories }} test

docker:
name: Lint Dockerfile
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
- name: Lint Dockerfile
uses: hadolint/hadolint-action@v1.6.0
with:
failure-threshold: error
recursive: true
46 changes: 46 additions & 0 deletions .github/workflows/security.yml
@@ -0,0 +1,46 @@
name: Security vulnerability scanner

on:
push:
branches: ["master"]

concurrency:
cancel-in-progress: true
group: security-${{ github.ref }}

jobs:
register:
name: Register images
runs-on: ubuntu-latest
steps:
- name: Register docker image for frontend
uses: SocialGouv/actions/autodevops-build-register@local-cache-cdtn
with:
project: "cdtn-admin"
imageName: cdtn-admin/cdtn-admin-frontend
token: ${{ secrets.GITHUB_TOKEN }}
dockerfile: "./targets/frontend/Dockerfile"
dockercontext: "./targets/frontend/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on pourrait faire une matrix ici dans le futur comme ça avec trivy en bas, ça va bien correspondre


trivy:
name: Run trivy
runs-on: ubuntu-18.04
needs: [register]
strategy:
fail-fast: false
matrix:
images: ["cdtn-admin-frontend"]
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Build ${{ matrix.images }} from Dockerfile
run: |
docker build -t ghcr.io/socialgouv/cdtn-admin/${{ matrix.images }}:sha-${{ github.sha }} .
- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
with:
image-ref: "ghcr.io/socialgouv/cdtn-admin/${{ matrix.images }}:sha-${{ github.sha }}"
format: "table"
ignore-unfixed: true
vuln-type: "os,library"
severity: "CRITICAL,HIGH"
15 changes: 15 additions & 0 deletions .github/workflows/sync-gitlab.yml
@@ -0,0 +1,15 @@
name: Gitlab mirroring

on:
- push
- delete

jobs:
mirror_gitlab:
name: 🪞 Gitlab
runs-on: ubuntu-latest
steps:
- uses: SocialGouv/actions/mirror-gitlab@master
with:
project: SocialGouv/cdtn/cdtn-admin
token: ${{ secrets.SOCIALGROOVYBOT_GITLAB_TOKEN }}
15 changes: 0 additions & 15 deletions .github/workflows/🇫🇷.yml

This file was deleted.

21 changes: 0 additions & 21 deletions Dockerfile

This file was deleted.

3 changes: 3 additions & 0 deletions package.json
Expand Up @@ -23,5 +23,8 @@
"name": "cdtn-admin",
"volta": {
"node": "14.18.0"
},
"engines": {
"node": "v14.18.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sre sans ça la github action est en node 16. C'est la bonne approche ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ca permet de forcer la gh-action en 14 ? stylé !
si ca permet de ne pas le specifier aussi dans le workflow ca me parait top

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non, malheureusement. Ca permet de spécifier la version de node attendue par yarn. Pour la github workflow, on a dû utiliser l'action setup-nodes.

- uses: actions/setup-node@v2
        with:
          node-version: '14.18.0'

Cela me semble être la bonne approche, je ne vois pas comment préciser la version de node différement dans une action github. Et ça me semble logique car cela fait partie du test aussi.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ok, j'avais espéré que l'action exploite cette info dans le package.json 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nb: il y a possibilité d'utiliser un .nvmrc actions/setup-node#338

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu ! :)

}
}
30 changes: 0 additions & 30 deletions targets/alert-cli/.gitlab-ci.yml
Expand Up @@ -31,36 +31,6 @@
#
#

🃏 test alert:
extends:
- .autodevops_test
- .cdtn_base_rules
image: node:14.18.0-alpine3.11
needs:
- job: 🧶 install alert
artifacts: true
- job: 📦 Dila resolver
artifacts: true
before_script:
- cd targets/alert-cli

🔬 lint alert:
extends:
- .autodevops_lint
- .cdtn_base_rules
image: node:14.18.0-alpine3.11
needs:
- job: 🧶 install alert
artifacts: true
- job: 📦 Dila resolver
artifacts: true
before_script:
- cd targets/alert-cli

#
#
#

📦 build alert:
extends:
- .base_yarn_script
Expand Down
26 changes: 0 additions & 26 deletions targets/frontend/.gitlab-ci.yml
Expand Up @@ -31,32 +31,6 @@
#
#

🃏 test www:
extends:
- .autodevops_test
- .cdtn_base_rules
needs:
- job: 🧶 install www
artifacts: true
before_script:
- cd targets/frontend

🔬 lint www:
extends:
- .autodevops_lint
- .cdtn_base_rules
needs:
- job: 📦 logger
artifacts: true
- job: 🧶 install www
artifacts: true
before_script:
- cd targets/frontend

#
#
#

📦 build www:
extends:
- .base_yarn_build_next
Expand Down
27 changes: 0 additions & 27 deletions targets/ingester-elasticsearch/.gitlab-ci.yml
Expand Up @@ -31,33 +31,6 @@
#
#

🃏 test ingester-elasticsearch:
extends:
- .autodevops_test
- .cdtn_base_rules
needs:
- job: 🧶 install ingester-elasticsearch
artifacts: true
before_script:
- cd targets/ingester-elasticsearch

🔬 lint ingester-elasticsearch:
extends:
- .autodevops_lint
- .cdtn_base_rules
needs:
- job: 🧶 install ingester-elasticsearch
artifacts: true
before_script:
- cd targets/ingester-elasticsearch
script:
- yarn types
- yarn lint

#
#
#

📦 build ingester-elasticsearch:
extends:
- .base_yarn_script
Expand Down