Update minio-go dependency
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2
ghost
requested review from
|
Not sure why we use the Minio library here instead of the default AWS SDK. |
This was a suggestion from @frank-sneller when he gave me the task. At the end it doesn't matter which module to use here I think. The AWS SDK is more complicated to use (imho) and might distract from the actual code that we want to showcase in this example project. |
|
The AWS SDK is pretty big and large, so the minio library is a bit more lean and mean. But in the end both will accomplish the same thing. |
|
Is it ok to merge this? |
ramondeklein
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2