Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of second GetObject() call inside of sizeWithoutTrailer() #2

Closed
ghost opened this issue May 4, 2022 · 0 comments · Fixed by #3
Closed

Get rid of second GetObject() call inside of sizeWithoutTrailer() #2

ghost opened this issue May 4, 2022 · 0 comments · Fixed by #3
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 4, 2022 •
edited by ghost

Currently, sizeWithoutTrailer() internally calls GetObject() a second time, because of a MinIO bug that prevents us from correctly rewinding the reader offset using Seek(0, 0).

After the fix PR is merged, we can update the dependency and reuse the S3 object.
@ghost ghost added the enhancement New feature or request label May 4, 2022
@ghost ghost self-assigned this May 4, 2022
ghost pushed a commit that referenced this issue Aug 19, 2022
@flobernd
Update minio-go dependency
68f5f4a 
Closes #2
@ghost ghost mentioned this issue Aug 19, 2022
Merged
flobernd added a commit that referenced this issue Aug 26, 2022
@flobernd
Update minio-go dependency (#3)
f448bd7 
Closes #2

Co-authored-by: Florian Bernd <flobernd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update minio-go dependency SnellerInc/iondump
0 participants