[Snyk] Upgrade babel-eslint from 10.0.3 to 10.1.0 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliecurtis
force-pushed
the
snyk-upgrade-7c3874c4e3d806ff0d956f1b5a5356f2
branch
from
f04c8ff
to
b78d445
Compare
Snyk has created this PR to upgrade babel-eslint from 10.0.3 to 10.1.0. See this package in NPM: https://www.npmjs.com/package/babel-eslint See this project in Snyk: https://app.snyk.io/org/skyscanner/project/9360bf56-7683-431d-8912-ca31594f1e41?utm_source=github&utm_medium=upgrade-pr
olliecurtis
force-pushed
the
snyk-upgrade-7c3874c4e3d806ff0d956f1b5a5356f2
branch
from
b78d445
to
dbb402b
Compare
olliecurtis
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade babel-eslint from 10.0.3 to 10.1.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.The recommended version fixes:
SNYK-JS-ACORN-559469
Release notes
Package name: babel-eslint
-
10.1.0 - 2020-02-26
-
10.0.3 - 2019-08-25
from babel-eslint GitHub release notes10.1.0
Fixes #791, also eslint/eslint#12117
Some context: #793 (comment)
We ended up going with @JLHwung's PR #794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.
babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.
Commit messages
Package name: babel-eslint
Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs
[//]: # (snyk:metadata:{"dependencies":[{"name":"babel-eslint","from":"10.0.3","to":"10.1.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/skyscanner/project/9360bf56-7683-431d-8912-ca31594f1e41?utm_source=github&utm_medium=upgrade-pr","projectPublicId":"9360bf56-7683-431d-8912-ca31594f1e41","env":"prod","prType":"upgrade","vulns":["SNYK-JS-ACORN-559469"],"issuesToFix":[{"issueId":"SNYK-JS-ACORN-559469","severity":"high","title":"Regular Expression Denial of Service (ReDoS)","exploitMaturity":"no-known-exploit"}],"upgrade":["SNYK-JS-ACORN-559469"],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2020-02-26T00:13:23.677Z"},"templateVariants":[],"hasFixes":true,"isMajorUpgrade":false,"isBreakingChange":false})