LOOM-1362 BpkBannerAlertInner Class 2 Overrides #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://backpack.github.io/storybook-prs/3444 to see this build running in a browser. |
metalix2
reviewed
May 13, 2024
| // TODO: className to be removed | ||
| // eslint-disable-next-line @skyscanner/rules/forbid-component-props | ||
| return <AlignedIcon className={className} />; | ||
| return <span className={className}><AlignedIcon/></span>; |
There was a problem hiding this comment.
I wonder as the styling being set is only fill's. whether the classMap could just be a type to fill color?
There was a problem hiding this comment.
Though it seems withButtonAlignment doesn't accept additional props. I wonder why..
There was a problem hiding this comment.
Hi @metalix2 - were these questions connected to your conversation with Ollie, i.e. do they still apply?
|
Visit https://backpack.github.io/storybook-prs/3444 to see this build running in a browser. |
metalix2
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class 2 Overrides:
<span>wrapper.Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md