[LOOM-1363][BpkButton]: Refactor BpkButtonV1 #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://backpack.github.io/storybook-prs/3443 to see this build running in a browser. |
|
Approved visual changes (adding new VT for Button V1) |
|
Visit https://backpack.github.io/storybook-prs/3443 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3443 to see this build running in a browser. |
metalix2
reviewed
May 14, 2024
|
|
||
| export { default } from './src/BpkButtonLinkOnDark'; | ||
| const BpkButtonPrimary = (props: Props) => <BpkButton {...props} /> |
There was a problem hiding this comment.
Here if it's not defined the default is bpk-button should it be PrimaryOnLight? or is default === primary ?
There was a problem hiding this comment.
Logic taken from:
metalix2
reviewed
May 14, 2024
|
|
||
| import BpkButton, {type Props} from './src/BpkButton'; | ||
|
|
||
| const BpkButtonPrimaryOnLight = (props: Props) => <BpkButton {...props} primaryOnLight /> |
There was a problem hiding this comment.
I guess this is definitely primaryOnLight 😅
FireRedNinja
pushed a commit
that referenced
this pull request
May 22, 2024
* remove button layers of abstraction * remove dummy fn * move tests, move proptypes back * add v1 visual stories, add cssModules to basebutton, update snaps
KathyWang0208
pushed a commit
that referenced
this pull request
May 27, 2024
* remove button layers of abstraction * remove dummy fn * move tests, move proptypes back * add v1 visual stories, add cssModules to basebutton, update snaps
KathyWang0208
pushed a commit
that referenced
this pull request
May 27, 2024
* remove button layers of abstraction * remove dummy fn * move tests, move proptypes back * add v1 visual stories, add cssModules to basebutton, update snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md