Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOOM-1319][BpkDividedCard]: Remove className from BpkCard #3440

Merged
merged 8 commits into from May 15, 2024
Merged

Conversation

mungodewar
Copy link
Contributor

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@mungodewar mungodewar added the minor Non breaking change label May 13, 2024
@@ -42,7 +42,6 @@ export type Props = {
};

const BpkDividedCard = ({
className = null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although className has been removed here, it will still be passed into BpkCard within the {...rest} props. This is unavoidable and is required to persist to support existing consumer className usage.

@mungodewar mungodewar marked this pull request as ready for review May 13, 2024 10:21
Copy link

Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser.

Copy link

github-actions bot commented May 13, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 874f2fd

Copy link
Contributor

@metalix2 metalix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser.

Comment on lines +39 to +45
&--no-elevation {
box-shadow: none;

&::after {
box-shadow: none;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from BpkDividedCard.

Copy link

Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser.

Copy link
Contributor

@metalix2 metalix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mungodewar mungodewar merged commit 004214f into main May 15, 2024
9 checks passed
@mungodewar mungodewar deleted the loom-1319 branch May 15, 2024 09:00
FireRedNinja pushed a commit that referenced this pull request May 22, 2024
* remove className from BpkCard

* formatting and update snaps

* add internal CardContext to pass elevation detail to BpkCard

* update snaps

* fixup BpkDividedCard

* add licence header to context file

* remove no-elevation from BpkDividedCard
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
* remove className from BpkCard

* formatting and update snaps

* add internal CardContext to pass elevation detail to BpkCard

* update snaps

* fixup BpkDividedCard

* add licence header to context file

* remove no-elevation from BpkDividedCard
KathyWang0208 pushed a commit that referenced this pull request May 27, 2024
* remove className from BpkCard

* formatting and update snaps

* add internal CardContext to pass elevation detail to BpkCard

* update snaps

* fixup BpkDividedCard

* add licence header to context file

* remove no-elevation from BpkDividedCard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants