-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOOM-1319][BpkDividedCard]: Remove className from BpkCard #3440
Conversation
@@ -42,7 +42,6 @@ export type Props = { | |||
}; | |||
|
|||
const BpkDividedCard = ({ | |||
className = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although className has been removed here, it will still be passed into BpkCard within the {...rest}
props. This is unavoidable and is required to persist to support existing consumer className
usage.
Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser. |
&--no-elevation { | ||
box-shadow: none; | ||
|
||
&::after { | ||
box-shadow: none; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from BpkDividedCard
.
Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3440 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
* remove className from BpkCard * formatting and update snaps * add internal CardContext to pass elevation detail to BpkCard * update snaps * fixup BpkDividedCard * add licence header to context file * remove no-elevation from BpkDividedCard
* remove className from BpkCard * formatting and update snaps * add internal CardContext to pass elevation detail to BpkCard * update snaps * fixup BpkDividedCard * add licence header to context file * remove no-elevation from BpkDividedCard
* remove className from BpkCard * formatting and update snaps * add internal CardContext to pass elevation detail to BpkCard * update snaps * fixup BpkDividedCard * add licence header to context file * remove no-elevation from BpkDividedCard
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md