Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BpkCardList #3076

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

BpkCardList #3076

wants to merge 56 commits into from
+3,900 −0

Conversation

FireRedNinja
Copy link
Contributor

@FireRedNinja FireRedNinja commented Nov 8, 2023 •
edited

This PR add the new component BpkCardList.

Screenshots

Rail

image

Grid

image

Row

Stack

Remember to include the following changes:

  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited

Fails
🚫

The file logs/test.log contains the following warnings:
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Each child in a list should have a unique "key" prop.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
- Warning: Encountered two children with the same key,null. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 05f167c

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@olliecurtis olliecurtis added the minor Non breaking change label Nov 10, 2023
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

2 similar comments
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@FireRedNinja
update d.ts file
3c971d1 
Signed-off-by: Noel Rajan <leonr13@hotmail.co.uk>
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@youngji0827 youngji0827 marked this pull request as ready for review May 22, 2024 15:21
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FireRedNinja @olliecurtis