[No Jira] Fix warning Danger keeps reporting #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaundon
force-pushed
the
no-jira-fix-warning
branch
from
dde1bdc
to
b0d77d4
Compare
|
I'm going to YOLO this through and see if it breaks CI on master. It's a one liner in our package.json so I can't see how it's breaking anything! If it breaks master I'll jump on it and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately, Danger keeps reporting build log warnings in every PR — like this: #1995 (comment).
I looked into it and it's a warning from
handlebars. We don't use this, but it's a dependency ofjest. Apparently they messed something up in a release and it was causing errors whenjest --coverageis run.I followed jestjs/jest#9396 (comment) to fix it, by making the coverage reports just print in text (which is how we were using it before, so nothing should change).
If it's worked, Danger shouldn't report any build log warnings on this PR.