Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO JIRA]: Clean up and remove cycle dependency #56

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[NO JIRA]: Clean up and remove cycle dependency #56

merged 2 commits into from
Nov 1, 2023

Conversation

xalechez
Copy link
Contributor

@xalechez xalechez commented Nov 1, 2023 •
edited

Remember to include the following changes:

  • CHANGELOG.md (Add the type of change and description under UNRELEASED according to Semver).
  • README.md
  • Tests

olliecurtis
olliecurtis requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@olliecurtis olliecurtis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry for this change? As this repo isn't on automated releases as it wasn't intended to be around for as long or recieve much update

@xalechez
Copy link
Contributor Author

xalechez commented Nov 1, 2023

Can you add a changelog entry for this change? As this repo isn't on automated releases as it wasn't intended to be around for as long or recieve much update

Done

@olliecurtis olliecurtis merged commit 6342ab6 into main Nov 1, 2023
1 check passed
@olliecurtis olliecurtis deleted the nojira_cleaning_up branch November 1, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliecurtis olliecurtis olliecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xalechez @olliecurtis