# Fix 144 Add cop warning for sleep #164
Conversation
| module RuboCop | ||
| module Cop | ||
| module SketchupSuggestions | ||
| # Avoid kernel `sleep` as it freezes up SketchUp. |
There was a problem hiding this comment.
How about:
Avoid kernel
sleepas it makes SketchUp unresponsive for the duration of the sleep. This is a poor user experience as it's difficult for the end user to determine if the application stopped working or not.
PreferUI.start_timeror a callback from the resource you are waiting for.
There was a problem hiding this comment.
I think "freezes SketchUp" is a more concise way to put the first part.
It's the "callback for the resource you are waiting for" part I'm unsure about. Is "callback for" better than "callback for"?
There was a problem hiding this comment.
Is "callback for" better than "callback for"
looks the same to me... ?
|
Test |
| # for. | ||
| class Sleep < SketchUp::Cop | ||
| MSG = '`sleep` freezes up SketchUp. Prefer `UI.start_timer` or a '\ | ||
| 'callback for the resource you are waiting for.' |
There was a problem hiding this comment.
Not sure how to best phrase this sentence. A callback for or a callback from?
| module RuboCop | ||
| module Cop | ||
| module SketchupSuggestions | ||
| # Avoid kernel `sleep` as it freezes up SketchUp. |
There was a problem hiding this comment.
I think "freezes SketchUp" is a more concise way to put the first part.
It's the "callback for the resource you are waiting for" part I'm unsure about. Is "callback for" better than "callback for"?
Add suggestion cop against
sleepas it freezes up SketchUp.Mostly unsure how to best phrase the messages/documentation.