Correct the output path of rake new_cop.
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomthom
force-pushed
the
dev/cop-generator
branch
2 times, most recently
from
158cab0
to
be2f2a8
Compare
Eneroth3
requested changes
Mar 20, 2023
lib/rubocop/sketchup/generator.rb
Outdated
| 'rubocop', | ||
| 'sketchup', # We have our cops nested one extra level. | ||
| 'cop', | ||
| snake_case(badge.department.to_s), |
There was a problem hiding this comment.
Shouldn't this also remove "sketchup_"?
If the command is:
bundle exec rake new_cop[SketchupRequirements/CopName]
The path should be:
lib/rubocop/sketchup/cop/requirements/cop_name.rb
not:
lib/rubocop/sketchup/cop/sketchup_requirements/cop_name.rb
There was a problem hiding this comment.
Indeed! Good catch! I'll fix!
There was a problem hiding this comment.
Fixed:
C:\Users\Thomas\SourceTree\rubocop-sketchup>bundle exec rake new_cop[SketchupRequirements/CopName]
[create] lib/rubocop/sketchup/cop/requirements/cop_name.rb
[create] spec/rubocop/cop/sketchup_requirements/cop_name_spec.rb
[modify] A configuration for the cop is added into config/default.yml.
Do 4 steps:
1. Modify the description of SketchupRequirements/CopName in config/default.yml
2. Implement your new cop in the generated file!
3. Commit your new cop with a message such as
e.g. "Add new `SketchupRequirements/CopName` cop"
4. Run `bundle exec rake changelog:new` to generate a changelog entry
for your new cop.
Eneroth3
approved these changes
Mar 20, 2023
thomthom
force-pushed
the
dev/cop-generator
branch
from
2bc21d8
to
001356b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the RuboCop config to include the latest RuboCop cops.