Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageSharp.Tests.ProfilingSandbox.csproj #1636

Merged
merged 1 commit into from
May 27, 2021

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented May 27, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

There's a breaking change in the .NET SDK 5.300 that affects our sandbox reference. This PR disables the check so we can build the solution. (I would like to delete the sandbox one day, we can profile using our Rider licenses)

See dotnet/docs#24231 for more info.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1636 (93f2322) into master (a29653f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         812      812           
  Lines       35594    35594           
  Branches     4144     4144           
=======================================
  Hits        29933    29933           
  Misses       4842     4842           
  Partials      819      819           
Flag Coverage 螖
unittests 84.09% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a21f8a4...93f2322. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit a2703b7 into master May 27, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/fix-msbuild branch May 27, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant