-
Notifications
You must be signed in to change notification settings - Fork 43k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow plugins to be loaded from folders and don't crash on exceptions #4546
allow plugins to be loaded from folders and don't crash on exceptions #4546
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4546 +/- ##
==========================================
+ Coverage 69.65% 69.80% +0.14%
==========================================
Files 72 72
Lines 3523 3553 +30
Branches 562 570 +8
==========================================
+ Hits 2454 2480 +26
- Misses 881 884 +3
- Partials 188 189 +1
☔ View full report in Codecov by Sentry. |
Oh oops it looks like we both did a similar thing at the same time. Here's my solution: #4548 |
the two of you should probably team up - by the way, that's why it's a good idea to always communicate your plans upfront, and that is why it's possible to create "draft PRs" |
There are lots of rad refactorings, log statements, and catches in here. I think they're great but can we change this PR to be just for the improvements to logging/exceptions, and then move folder-loading to my PR? #4548 My PR covers just folder-loading, but none of the improvements you've made. My PR adds requirements scanning which is necessary if we're going to enable folder-loading. LMK what you think. |
Sounds good to me |
I'm happy to work together. I'll look at it in more detail on Monday |
note that it's generally a good idea to mutually review your PRs and to ensure that the CI pipeline is happy (by adding/extending tests/coverage as needed) |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Closing this as resolved in #4548 :) |
Background
In order to make plugin development (or just plugin installing & updating) easier it should be possible to load plugins without the code be in a zib format. Furthermore changes in the template can cause a specific plugin to stop loading. This shouldn't crash autogpt as a whole.
This way i can git checkout the plugins repository into the plugins folder and it 'just works'. See also the discussion #3654
Changes
Documentation
Test Plan
I tested loading plugins both in zip and non-zib format
PR Quality Checklist