[release_2.0] Write auto-created private data dirs to pytest dir inst…

…ead of /tmp (ansible#916) (ansible#942)

[release_2.0] Write auto-created private data dirs to pytest dir instead of /tmp (ansible#916)

Backport of ansible#916 for Ansible Runner 2.0.

Reviewed-by: David Shrewsbury <None>
Reviewed-by: None <None>

ansible_runner/config/_base.py

@@ -93,7 +93,7 @@ def __init__(self,
             # attempt to compromise the directories via a race.
             os.makedirs(self.private_data_dir, exist_ok=True, mode=0o700)
         else:
-            self.private_data_dir = tempfile.mkdtemp(prefix=".ansible-runner-")
+            self.private_data_dir = tempfile.mkdtemp(prefix=defaults.AUTO_CREATE_NAMING, dir=defaults.AUTO_CREATE_DIR)
 
         if artifact_dir is None:
             artifact_dir = os.path.join(self.private_data_dir, 'artifacts')

ansible_runner/defaults.py

@@ -1,2 +1,7 @@
 default_process_isolation_executable = 'podman'
 default_container_image = 'quay.io/ansible/ansible-runner:devel'
+
+# values passed to tempfile.mkdtemp to generate a private data dir
+# when user did not provide one
+AUTO_CREATE_NAMING = '.ansible-runner-'
+AUTO_CREATE_DIR = None

test/conftest.py

@@ -2,6 +2,8 @@
 
 from distutils.version import LooseVersion
 
+from ansible_runner import defaults
+
 import pkg_resources
 import pytest
 
@@ -17,6 +19,11 @@ def mock_env_user(monkeypatch):
     monkeypatch.setenv("ANSIBLE_DEVEL_WARNING", "False")
 
 
+@pytest.fixture(autouse=True)
+def change_save_path(tmp_path, mocker):
+    mocker.patch.object(defaults, 'AUTO_CREATE_DIR', str(tmp_path))
+
+
 @pytest.fixture(scope='session')
 def is_pre_ansible28():
     try: