Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing peer dependencies in eslint-plugin and stylelint-plugin #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matwilko
Copy link

Description

@shopify/eslint-plugin and @shopify/stylelint-plugin are missing peerDependencies on @babel/core and prettier.

While it's not a massive problem, it does make life harder for package managers when trying to optimize package installation, see Implicit Transitive Peer Dependencies.

yarn currently reports both of these packages as missing peer dependencies:

➤ YN0000: @shopify/eslint-plugin@npm:42.1.0 doesn't provide @babel/core, breaking the following requirements:
➤ YN0000: @babel/eslint-parser@npm:7.22.9 → >=7.11.0

➤ YN0000: @shopify/eslint-plugin@npm:42.1.0 doesn't provide prettier, breaking the following requirements:
➤ YN0000: eslint-plugin-prettier@npm:4.2.1 → >=2.0.0

➤ YN0000: @shopify/stylelint-plugin@npm:12.0.1 doesn't provide prettier, breaking the following requirements:
➤ YN0000: stylelint-prettier@npm:3.0.0 → >=2.0.0

Noted both changes as patch, because consumers will already have been required to fulfil these requirements, so it's not forcing them to upgrade or install new packages with potential breaking changes.

@matwilko
Copy link
Author

Note: I know the CLA needs signing, it just requires internal approval first, should only be a few days :)

@matwilko
Copy link
Author

matwilko commented Aug 3, 2023

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant