Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js 16 support and update stylelint-plugin deps #298

Merged
merged 5 commits into from Nov 2, 2021
Merged

Add Node.js 16 support and update stylelint-plugin deps #298

merged 5 commits into from Nov 2, 2021

Conversation

atesgoral
Copy link
Contributor

@atesgoral atesgoral commented Nov 1, 2021 •
edited

Description

  • Bump the Node.js for local development to 16.3.0.
  • Add an engines prop to package.json
  • Update stylelint-plugin deps:

Pertinent/breaking parts of changelogs for deps

stylelint-config-prettier 8.0.1 -> 9.0.3

v9.0.0

  • Updates rules
  • Adds SCSS rule resets

stylelint-order 4.0.0 -> 5.0.0

5.0.0

  • Breaking change: Dropped Node.js 8 support. Node.js 12 or greater is now required.
  • Breaking change: Dropped support for Stylelint 13 and earlier.
  • Added support for Stylelint 14.

stylelint-scss 3.19.0 -> 4.0.0

4.0.0

  • Removed: stylelint@13 support.
  • Added: stylelint@14 support.

stylelint 13.12.0 -> 14.0.1

14.0.0

Migration guide

  • Removed: Node.js 10 support
  • Removed: syntax option
  • Removed: configOverrides option
  • Removed: rules deprecated in 13.7.0
  • Removed: function-calc-no-invalid rule
  • Changed: ignoreFiles to be extendable

Type of change

  • stylelint-plugin Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@atesgoral atesgoral marked this pull request as ready for review November 1, 2021 20:17
@atesgoral atesgoral requested a review from a team November 1, 2021 20:18
@dahukish dahukish changed the title Bump Node.js to 16.3.0 Bump Node.js to 16.13.0 Nov 1, 2021
dahukish
dahukish reviewed Nov 1, 2021
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
michenly
michenly reviewed Nov 1, 2021
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@atesgoral atesgoral marked this pull request as draft November 1, 2021 22:48
@atesgoral atesgoral changed the title Bump Node.js to 16.13.0 Bump Node.js to 16.13.0 and update stylelint-plugin deps Nov 1, 2021
BPScott
BPScott reviewed Nov 2, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@atesgoral atesgoral changed the title Bump Node.js to 16.13.0 and update stylelint-plugin deps Add Node.js 16 support and update stylelint-plugin deps Nov 2, 2021
@atesgoral atesgoral marked this pull request as ready for review November 2, 2021 14:33
michenly
michenly reviewed Nov 2, 2021
View reviewed changes
packages/stylelint-plugin/package.json
},
"peerDependencies": {
"stylelint": ">=13.12.0"
"stylelint": ">=14.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@atesgoral
Copy link
Contributor Author

atesgoral commented Nov 2, 2021 •
edited

  • Will add a CHANGELOG entry for stylelint-plugin

@michenly I added a CHANGELOG entry.

@atesgoral atesgoral merged commit c83add2 into main Nov 2, 2021
@atesgoral atesgoral deleted the node-16 branch November 2, 2021 15:10
@atesgoral atesgoral mentioned this pull request Nov 5, 2021
Merged
@shopify-shipit shopify-shipit bot temporarily deployed to production November 18, 2021 15:38 Inactive
@BPScott BPScott mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BPScott BPScott BPScott left review comments

@dahukish dahukish dahukish left review comments

@michenly michenly michenly approved these changes

@marutypes marutypes marutypes approved these changes

@vsumner vsumner Awaiting requested review from vsumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atesgoral @BPScott @dahukish @michenly @marutypes