Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint to 13.13.1 #248

Closed
wants to merge 1 commit into from
Closed

Update stylelint to 13.13.1 #248

wants to merge 1 commit into from

Conversation

vsumner
Copy link
Contributor

@vsumner vsumner commented May 10, 2021

Description

Update stylelint to version 13.13.1

Changelog: https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md#13131

New rules:

  • Added: no-invalid-position-at-import-rule rule (#5202).
  • Added: no-irregular-whitespace rule (#5209).
  • Added: selector-disallowed-list rule (#5239).
  • Added: selector-attribute-quotes autofix (#5248).
  • Added: ignore: ["inside-function"] to declaration-property-unit-allowed-list (#5194).

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • @shopify/stylelint-plugin Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@dahukish
Copy link
Contributor

dahukish commented Oct 7, 2021

@vsumner can we close this?

@vsumner
Copy link
Contributor Author

vsumner commented Oct 7, 2021

🤷 Up to you. It needs to happen at some point.

@BPScott
Copy link
Member

BPScott commented Nov 26, 2021

Going to close this. Consumers can pick up the latest 13.x release because the peer dep is a range. I'll be opening up a PR to require stylelint 14 in the near future

@BPScott BPScott closed this Nov 26, 2021
@BPScott BPScott deleted the stylelint-13.13.1 branch November 26, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants