Merge pull request #399 from Shopify/update-eslint

update eslint plugins
Shopify · Aug 9, 2023 · 5149cf4 · 5149cf4
2 parents 268e5a2 + b821f24
commit 5149cf4
Show file tree

Hide file tree

Showing 7 changed files with 1,706 additions and 1,309 deletions.
diff --git a/.changeset/pretty-gorillas-dress.md b/.changeset/pretty-gorillas-dress.md
@@ -0,0 +1,5 @@
+---
+'@shopify/eslint-plugin': major
+---
+
+upgrade @typescript-eslint and eslint plugins and drop support for node 14
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: ['14.x', '16.x', '18.x']
+        node-version: ['16.x', '18.x', '20.x']
     timeout-minutes: 10
 
     steps:

diff --git a/package.json b/package.json
@@ -15,14 +15,14 @@
     "tophat": "tophat"
   },
   "devDependencies": {
-    "@changesets/changelog-github": "^0.4.7",
-    "@changesets/cli": "^2.25.0",
+    "@changesets/changelog-github": "^0.4.8",
+    "@changesets/cli": "^2.26.1",
     "@shopify/tophat": "^0.0.4",
     "@types/jest": "^26.0.24",
     "eslint": "^8.3.0",
     "fs-extra": "^9.0.0",
     "glob": "^7.1.6",
-    "jest": "^27.0.6",
+    "jest": "^29.6.2",
     "plop": "^2.6.0",
     "prettier": "^3.0.1",
     "watchpack": "^2.2.0"

diff --git a/packages/eslint-plugin/lib/config/jest.js b/packages/eslint-plugin/lib/config/jest.js
@@ -44,8 +44,6 @@ module.exports = {
     'jest/no-test-return-statement': 'error',
     // Enforce lowercase test names
     'jest/prefer-lowercase-title': ['error', {ignore: ['describe']}],
-    // Disallow importing Jest
-    'jest/no-jest-import': 'error',
     // Disallow alias methods
     'jest/no-alias-methods': 'error',
     // Disallow setup and teardown hooks

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -27,24 +27,24 @@
   "dependencies": {
     "@babel/eslint-parser": "^7.16.3",
     "@babel/eslint-plugin": "^7.14.5",
-    "@typescript-eslint/eslint-plugin": "^5.4.0",
-    "@typescript-eslint/parser": "^5.4.0",
+    "@typescript-eslint/eslint-plugin": "^6.2.1",
+    "@typescript-eslint/parser": "^6.2.1",
     "change-case": "^4.1.2",
     "common-tags": "^1.8.2",
     "doctrine": "^2.1.0",
     "eslint-config-prettier": "^8.10.0",
     "eslint-module-utils": "^2.7.1",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^25.3.0",
+    "eslint-plugin-import": "^2.28.0",
+    "eslint-plugin-jest": "^27.2.3",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsx-a11y": "^6.5.0",
+    "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-promise": "^6.0.0",
-    "eslint-plugin-react": "^7.30.0",
-    "eslint-plugin-react-hooks": "^4.3.0",
-    "eslint-plugin-sort-class-members": "^1.14.0",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-react": "^7.33.1",
+    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-sort-class-members": "^1.18.0",
     "jsx-ast-utils": "^3.2.1",
     "pkg-dir": "^5.0.0",
     "pluralize": "^8.0.0"
@@ -54,6 +54,6 @@
   },
   "devDependencies": {
     "react": "^16.13.1",
-    "typescript": "^3.9.2"
+    "typescript": "^5.0.0"
   }
 }
diff --git a/packages/eslint-plugin/tests/lib/config/typescript.test.js b/packages/eslint-plugin/tests/lib/config/typescript.test.js
@@ -21,7 +21,7 @@ describe('config', () => {
     );
 
     expect(esLintOutput).toStrictEqual(
-      expect.stringContaining('2 problems (2 errors, 0 warnings)'),
+      expect.stringContaining('3 problems (3 errors, 0 warnings)'),
     );
 
     // import/no-cycle error