Always run tests with --no-doc unless specified otherwise
#932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
vinistock
approved these changes
May 16, 2022
|
As shown here, we're back to ~10min 🎉
|
KaanOzkan
approved these changes
May 26, 2022
paracycle
approved these changes
May 30, 2022
paracycle
added a commit
that referenced
this pull request
May 30, 2022
Always run tests with `--no-doc` unless specified otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following #920, running the test suite increased from 10 to 40 minutes because we spend a lot of time parsing and generating the documentation in the gem RBIs.
Implementation
Always pass
--no-docunless--docis passed explicitly.Tests
See automated tests.