Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check duplicates between shims and Sorbet's RBI payload #879

Merged
merged 7 commits into from Apr 7, 2022
Merged

Check duplicates between shims and Sorbet's RBI payload #879

merged 7 commits into from Apr 7, 2022

Commits on Apr 5, 2022

  1. Check shims for duplicates from Sorbet's payload 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Kaan Ozkan <kaan.ozkan@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
    @Morriar @KaanOzkan @vinistock
    3 people committed Apr 5, 2022
    Copy the full SHA
    0326688 View commit details
    Browse the repository at this point in the history

  2. Nest check-shims tests under an additional describe 

    Extracted in this commit to avoid a bigger, harder to read change in the next one.
No functional change here.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    99f51bc View commit details
    Browse the repository at this point in the history

  3. Add test for check-shims --payload 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    c083f76 View commit details
    Browse the repository at this point in the history

  4. Add test checking the version gate on check-shims --payload 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    35bb67c View commit details
    Browse the repository at this point in the history

  5. Speed up default tests on check-shims --no-payload 

    Dumping, parsing and indexing Sorbet's payload takes around ~5s.
We don't need to waste this time in most tests here.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    c9cb6b9 View commit details
    Browse the repository at this point in the history

  6. Remove duplicated shim for Bundler 

    This definition is duplicated from https://github.com/sorbet/sorbet/blob/master/rbi/stdlib/bundler.rbi#L9958.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    c30a8bb View commit details
    Browse the repository at this point in the history

  7. Update README with new --payload option 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Apr 5, 2022
    Copy the full SHA
    91dcde9 View commit details
    Browse the repository at this point in the history