Check generated RBI files for correctness #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
commented
Mar 4, 2022
| update_gem_rbis_strictnesses([], gem_dir: @gem_dir, dsl_dir: @outpath.to_s) | ||
| say("") | ||
| validate_rbi_files( | ||
| command: default_command(:dsl, @requested_constants.join(" ")), |
There was a problem hiding this comment.
It would be better to use the real Thor command here but I believe it would require a lot of refactoring
Morriar
force-pushed
the
at-check-parse-errors
branch
2 times, most recently
from
229791c
to
8446ab7
Compare
paracycle
approved these changes
Mar 4, 2022
| update_gem_rbis_strictnesses([], gem_dir: @gem_dir, dsl_dir: @outpath.to_s) | ||
| say("") | ||
| validate_rbi_files( | ||
| command: default_command(:dsl, @requested_constants.join(" ")), |
Morriar
force-pushed
the
at-check-parse-errors
branch
from
8446ab7
to
94699a3
Compare
Morriar
commented
Mar 25, 2022
| @@ -48,10 +107,8 @@ def update_gem_rbis_strictnesses(gem_names, gem_dir: DEFAULT_GEM_DIR, dsl_dir: D | |||
| files | |||
| .uniq | |||
| .sort | |||
| .select do |file| | |||
| name = gem_name_from_rbi_path(file) | |||
| file.start_with?(gem_dir) && (gem_names.empty? || gem_names.include?(name)) | |||
There was a problem hiding this comment.
Before the auto fix of the typed-override was only applied on requested gems but it doesn't make sense as a newly generated RBI can produce conflicts in old RBIs so I removed the feature.
Morriar
commented
Mar 25, 2022
| @@ -1356,30 +1356,6 @@ def quux(x); end | |||
| assert_success_status(result) | |||
| end | |||
|
|
|||
| it "must turn the strictness of files with error to false only in asked gems" do | |||
There was a problem hiding this comment.
Relative to the feature removed as explained in https://github.com/Shopify/tapioca/pull/842/files#r835335074.
vinistock
approved these changes
Mar 25, 2022
paracycle
approved these changes
Mar 28, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-check-parse-errors
branch
from
94699a3
to
7353935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Catches parse errors in generated RBI files and display a helpful error message:
Closes #759.
Implementation
Since we already run
sorbeton generated files to catch redefinition errors and change the strictness of generated files, I decided to hook on this process to check if we find parse errors (code < 4000) as well.Tests
See automated tests.