Add helper method underscore #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
May 10, 2021
vinistock
force-pushed
the
add_helper_method_underscore
branch
from
9eadc2e
to
124b164
Compare
Morriar
approved these changes
May 10, 2021
paracycle
approved these changes
May 10, 2021
vinistock
force-pushed
the
add_helper_method_underscore
branch
from
124b164
to
e26845b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
Motivation
We can't depend on active_support being available, so I moved our spec implementation of
underscoreinto a helper method so that we can use it in projects that do not include active_support.I considered adding it as a core extension to string, but I'm not a fan of that approach as it could potentially lead to mistakes. For example, a project including Tapioca could use
underscoreinStringduring development and it would work fine, but then would break outside of a development environment, where Tapioca is not included. This is why I made it a class method.Implementation
Move the implementation of
underscoreinto a helper class method insideGenerator. Please, let me know if we have a better place for utilities such as this one.Tests
This is a refactor. Existing tests already cover it.