Fix RBI generation for gems #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
commented
May 5, 2021
| @@ -49,7 +49,6 @@ module Baz; end | |||
|
|
|||
| class Baz::Role | |||
| include ::SmartProperties | |||
|
|
|||
There was a problem hiding this comment.
No more newline here since it's in the same group now.
Morriar
commented
May 5, 2021
| @@ -431,8 +431,8 @@ def self.m2; end | |||
| rbi << RBI::Class.new("S2") | |||
| rbi << RBI::Method.new("m1") | |||
| rbi << RBI::Method.new("m2", is_singleton: true) | |||
| rbi << RBI::Include.new("I") | |||
There was a problem hiding this comment.
Just changed the order in a few tests to show that we keep it when compiling.
Morriar
commented
May 5, 2021
| .gsub("<NOT-TYPED>", "T.untyped") | ||
| .gsub(".params()", "") | ||
|
|
||
| type = sanitize_signature_types(parameter_types[name.to_sym].to_s) |
There was a problem hiding this comment.
Factorized the sanitization so both params and return types are handled the same.
paracycle
approved these changes
May 5, 2021
vinistock
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My previous PR on RBI generation (#297) broke two things:
Grouping the include and extend in separate groups meant I changed the order in which they were generated and includes were always printed before extends which is actually incorrect. So the first commit (2bb2a7e) groups them together to get the right order again.
Both params types and return types need to be sanitized for weird types such as
<VOID>. It was done on the whole signature string before and I forgot to do it on parameters types. The second commit (86b2982) fixes this and adds a related test.With these fixes we can generate the RBIs for Shopify's core without any error! 馃帀
Tests
See included tests.