Compile T.type_alias #291
Merged
Compile T.type_alias #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
force-pushed
the
compile-type-alias
branch
from
a75a507
to
dd33c31
Compare
jeffcarbs
force-pushed
the
compile-type-alias
branch
from
dd33c31
to
bbb571f
Compare
jeffcarbs
force-pushed
the
compile-type-alias
branch
from
bbb571f
to
a31e49b
Compare
paracycle
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're have a
T.type_aliasdefined in an internal gem that we want to use inside a consuming application. Seems like it ought to come over in the RBI since the constant is available at runtime.Implementation
Currently tapioca ignores
T.type_aliassince it starts withT::Private::Types::. This PR updates the spot where that bailout happens and adds a special case to handle it.Tests
Extended one test and added another.