Fix problem with missing gem specs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
approved these changes
Jan 25, 2021
paracycle
changed the title
paracycle
force-pushed
the
uk-fix-materialize
branch
from
59af73a
to
2ceecac
Compare
Also run `bundle lock --add-platform=ruby` before running tests so that we end up installing the native executable of Nokogiri when we do `bundle install` which would exhibit the difference in behaviour.
Some specs could be missing when trying to materialized the spec set, for example, a gem could depend on another gem for one platform but not depend on it for the current platform, which would make that dependency exist in the lockfile but result in a missing spec for the current platform. The fix is to pass an empty array to `materialize` which would collect the names of the gems that have missing specs.
Since the minimum supported Ruby version of Nokogiri is 2.5
paracycle
force-pushed
the
uk-fix-materialize
branch
5 times, most recently
from
68c7a34
to
5d6cd8f
Compare
Gemfile
Outdated
| @@ -10,7 +10,7 @@ group(:deployment, :development) do | |||
| gem("rake") | |||
| end | |||
|
|
|||
| gem("bundler", "~> 1.17") | |||
| gem("bundler", ">= 2") | |||
There was a problem hiding this comment.
Should not bundler be in the gemspec since it is a runtime dependency? Can tapioca run without bundler being installed?
There was a problem hiding this comment.
Ooops, that's correct. Fixing it now.
rafaelfranca
approved these changes
Jan 26, 2021
Morriar
approved these changes
Jan 26, 2021
paracycle
force-pushed
the
uk-fix-materialize
branch
from
c4caaf4
to
cefea35
Compare
paracycle
force-pushed
the
uk-fix-materialize
branch
from
cefea35
to
db305d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #208.
Implementation
Bundler::SpecSet#materializehas an optional extra parameter that can be supplied an array, which will be used to collect the names of the missing gem specs when materializing. This prevents missing gem specs from raising errors, so by passing an empty array for this parameter, we can prevent Tapioca from crashing when it runs into missing specs for dependencies that don't make sense for the current platform.Tests
Added a
nokogiridependency on the test repo and added a test to ensure that its optional dependency does not get processed.