Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger matrix status check for push and PR events #1876

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

KaanOzkan
Copy link
Contributor

Motivation

Github uses commit status to set the status for the branch so we need this to run on pushes.

Implementation

Tests

@paracycle
Copy link
Member

I am sorry, I don't understand what this PR is trying to fix. We do have proper CI status for commits on main, for example. What's broken?

@Morriar
Copy link
Collaborator

Morriar commented Apr 18, 2024

I am sorry, I don't understand what this PR is trying to fix. We do have proper CI status for commits on main, for example. What's broken?

Isn't it to avoid skipping the final step that displays the aggregated build status:
image

@KaanOzkan
Copy link
Contributor Author

Yes we skip Build on pushes but its used for branch protection. Enabling the auto-merge on #1875 caused it to be merged with failing CI checks.

@KaanOzkan KaanOzkan added the chore label May 1, 2024
@KaanOzkan KaanOzkan merged commit 9f3dc1a into main May 1, 2024
34 of 35 checks passed
@KaanOzkan KaanOzkan deleted the ko/ci-status branch May 1, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants