Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify PR labels #1435

Closed
wants to merge 2 commits into from
Closed

Verify PR labels #1435

wants to merge 2 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 10, 2023 •
edited

Motivation

Closes Verify PR labels before merging

Implementation

There are a few other actions very similar to this, but this one seems to have the features we need, so I'm trying out.

Thoughts:

andyw8
andyw8 commented Mar 10, 2023
View reviewed changes
.github/workflows/require_label.yml Outdated
with:
mode: minimum
count: 1
labels: "documentation, bug, bugfix, chore, dependencies, enhancement, feature, gh-actions, ignore-for-release, security, sorbet"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this list from all the labels available, and removed the ones that seem irrelevant for the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also: https://github.com/Shopify/tapioca/blob/main/.github/release.yml

@andyw8 andyw8 mentioned this pull request Mar 10, 2023
Closed
@andyw8 andyw8 added the chore label Mar 10, 2023
@andyw8 andyw8 marked this pull request as ready for review March 13, 2023 18:27
@andyw8 andyw8 requested a review from a team as a code owner March 13, 2023 18:27
paracycle
paracycle reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make it add a comment to the PR that will explain when and why it is failing: https://github.com/marketplace/actions/require-labels#customising-the-failure-message--comment

.github/workflows/require_label.yml Outdated Show resolved Hide resolved
@andyw8 @paracycle
Update .github/workflows/require_label.yml
1ba0e83 
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
paracycle
paracycle reviewed Mar 15, 2023
View reviewed changes
.github/workflows/require_label.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to add a add_comment: true option, and possibly a message option, to explain why the PR can't be merged?

@andyw8
Copy link
Contributor Author

andyw8 commented Mar 15, 2023

We can only use public actions if the maintainer owner is a 'verified creator':

mheap/github-action-required-labels#48

I'll give it a few days but if that doesn't work out then I suppose we could fork it?

@andyw8
Copy link
Contributor Author

andyw8 commented Mar 16, 2023

Unfortunately this seems like a no-go:

mheap/github-action-required-labels#48 (comment)

@andyw8 andyw8 closed this May 17, 2023
@paracycle paracycle mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle left review comments

@Morriar Morriar Morriar left review comments

Assignees
No one assigned
Labels
chore ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify PR labels before merging
3 participants
@andyw8 @paracycle @Morriar