Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI against minimum supported Sorbet version #1252

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Run CI against minimum supported Sorbet version #1252

wants to merge 4 commits into from

Commits on Nov 8, 2022

  1. Match net-smtp versions across gemfiles 

    The main Gemfile specifies 0.3.2, but the other two specify 0.3.1.
    @sambostock
    sambostock committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e034d3b View commit details
    Browse the repository at this point in the history

  2. Refactor gemfiles 

    Rather than duplicate the entire file, we can use eval_gemfile.
    @sambostock
    sambostock committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    45b9e73 View commit details
    Browse the repository at this point in the history

  3. Use actual sorbet-static-and-runtime version 

    0.5.9896 is the first published version that is actually >= 0.5.9892
    @sambostock
    sambostock committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    0fc3114 View commit details
    Browse the repository at this point in the history

  4. Run CI against minimum supported Sorbet version 

    Extract minimum Sorbet version from gemspec and run against that to make
sure we're actually compatible.
    @sambostock
    sambostock committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1937577 View commit details
    Browse the repository at this point in the history