Skip to content

Commit

Permalink
Speed up default tests on check-shims --no-payload
Browse files Browse the repository at this point in the history
Dumping, parsing and indexing Sorbet's payload takes around ~5s.
We don't need to waste this time in most tests here.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
  • Loading branch information
Morriar committed Apr 1, 2022
1 parent 8a4471a commit b6a7edc
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions spec/tapioca/cli/check_shims_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Foo
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_equal(<<~OUT, result.out)
No shim RBIs to check
Expand All @@ -50,7 +50,7 @@ class Foo
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_equal(<<~OUT, result.out)
Loading shim RBIs from sorbet/rbi/shims... Done
Expand Down Expand Up @@ -88,7 +88,7 @@ def bar; end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_includes(result.err, <<~ERR)
Duplicated RBI for ::Bar#bar:
Expand Down Expand Up @@ -123,7 +123,7 @@ def foo; end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")
assert_success_status(result)
end

Expand All @@ -142,7 +142,7 @@ def foo; end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")
assert_success_status(result)
end

Expand Down Expand Up @@ -173,7 +173,7 @@ def baz(x, y); end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_includes(result.err, <<~ERR)
Duplicated RBI for ::Foo#foo:
Expand Down Expand Up @@ -204,7 +204,7 @@ class Foo
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_includes(result.err, <<~ERR)
Duplicated RBI for ::Foo#foo:
Expand Down Expand Up @@ -233,7 +233,7 @@ def foo; end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_includes(result.err, <<~ERR)
Duplicated RBI for ::Foo#foo:
Expand Down Expand Up @@ -314,7 +314,7 @@ def bar; end
RBI

result = @project.tapioca(
"check-shims --gem-rbi-dir=rbi/gem --dsl-rbi-dir=rbi/dsl --shim-rbi-dir=rbi/shim"
"check-shims --gem-rbi-dir=rbi/gem --dsl-rbi-dir=rbi/dsl --shim-rbi-dir=rbi/shim --no-payload"
)

assert_includes(result.err, <<~ERR)
Expand Down Expand Up @@ -355,7 +355,7 @@ def foo; end
end
RBI

result = @project.tapioca("check-shims")
result = @project.tapioca("check-shims --no-payload")

assert_includes(result.err, <<~ERR)
Warning: Unsupported block node type `foo` (sorbet/rbi/shims/foo.rbi:2:2-2:13)
Expand Down

0 comments on commit b6a7edc

Please sign in to comment.