This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Update Themekit version and themekit-node API #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
t-kelly
reviewed
Oct 3, 2019
| @@ -78,9 +69,9 @@ function _generateIgnoreFlags() { | |||
| * @return Promise | |||
| */ | |||
| async function deploy(cmd = '', files = []) { | |||
| if (!['upload', 'replace'].includes(cmd)) { | |||
| if (!['deploy', 'replace'].includes(cmd)) { | |||
There was a problem hiding this comment.
It looks like replace doesn't exist anymore? And has been replaced by deploy. And that upload has been replaced by deploy --nodelete?
There was a problem hiding this comment.
Yes, you're right. I'll update the the commands and documentation to reflect this when I get a chance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
fixes #1057 by updating themekit binary and themekit-node api calls to the latest version
Checklist
For contributors:
For maintainers: