Make shopify-extensions its own Ruby Gem extensions

ext/shopify-cli/extconf.rb

@@ -1,8 +1,6 @@
 require "rbconfig"
 require "fileutils"
-require_relative "./install_extension_server.rb"
 
-extension_server_version = "v0.1.0"
 gem = File.expand_path("../../../", __FILE__)
 exe = File.join(gem, "bin", "shopify")
 
@@ -35,12 +33,6 @@
     \t echo "@ECHO OFF"> "#{bat}"
     \t echo "#{script_content}">> "#{bat}"
   MAKEFILE
-
-  ShopifyCli::InstallExtensionServer.call(
-    version: extension_server_version,
-    source: "shopify-extensions.exe",
-    target: File.join(File.dirname(__FILE__), "shopify-extensions.exe")
-  )
 else
   script = exe + ".sh"
   symlink = "/usr/local/bin/shopify"
@@ -62,12 +54,6 @@
     install: clean
     \t@sudo ln -s #{script} #{symlink}
   MAKEFILE
-
-  ShopifyCli::InstallExtensionServer.call(
-    version: extension_server_version,
-    source: "shopify-extensions",
-    target: File.join(File.dirname(__FILE__), "shopify-extensions")
-  )
 end
 
 File.write("Makefile", makefile_content)

ext/shopify-extensions/extconf.rb

@@ -0,0 +1,15 @@
+require_relative "./shopify_extensions"
+
+File.write("Makefile", <<~MAKEFILE)
+  .PHONY: clean
+
+  clean: ;
+
+  install: ;
+MAKEFILE
+
+ShopifyExtensions.install(
+  version: "v0.1.0",
+  source: "shopify-extensions",
+  target: File.join(File.dirname(__FILE__), "shopify-extensions")
+)

ext/shopify-cli/install_extension_server.rb → ext/shopify-extensions/shopify_extensions.rb

@@ -1,28 +1,46 @@
-require 'open-uri'
-require 'json'
-require 'zlib'
-require 'rubygems'
-require 'rubygems/package'
-
-module ShopifyCli
-  class InstallExtensionServer
+require "rbconfig"
+require "open-uri"
+require "json"
+require "zlib"
+require "rubygems"
+require "rubygems/package"
+
+module ShopifyExtensions
+  class InstallationError < RuntimeError; end
+
+  def self.install(**args)
+    Install.call(**args)
+  end
+
+  class Install
     def self.call(platform: Platform.new, **args)
       new.call(platform: platform, **args)
     end
 
     def call(platform:, version:, source:, target:)
+      source = platform.format_path(source)
+      target = platform.format_path(target)
+
       releases
         .find { |release| release.version == version }
         .download(platform: platform, source: source, target: target)
 
-      raise "Failed to install extension development server" unless File.executable?(target)
-      raise "Failed to isntall the correct extension development server version" unless `#{target} version`.strip == version.strip
+      raise not_executable_error unless File.executable?(target)
+      raise incorrect_version_error unless %x(#{target} version).strip == version.strip
     end
 
     private
 
+    def not_executable_error
+      InstallationError.new("Failed to install shopify-extensions")
+    end
+
+    def incorrect_version_error
+      InstallationError.new("Failed to install the correct version of shopify-extensions")
+    end
+
     def releases
-      JSON.parse(URI.open(release_url).read).map(&Release)
+      JSON.parse(URI.parse(release_url).open.read).map(&Release)
     end
 
     def release_url
@@ -65,7 +83,7 @@ def self.to_proc
     def download(source:, target:)
       Dir.chdir(File.dirname(target)) do
         File.open(File.basename(target), "w") do |target_file|
-          unpack(source, from: decompress(URI.open(url)), to: target_file)
+          unpack(source, from: decompress(URI.parse(url).open), to: target_file)
         end
         File.chmod(0755, target)
       end
@@ -124,12 +142,21 @@ def initialize(ruby_config = RbConfig::CONFIG)
         super(ruby_config)
       end
 
+      def format_path(path)
+        case os
+        when "windows"
+          path + ".exe"
+        else
+          path
+        end
+      end
+
       def to_s
         format("%{os}-%{cpu}", os: os, cpu: cpu)
       end
 
       def os
-        case ruby_config.fetch('host_os')
+        case ruby_config.fetch("host_os")
         when /linux/
           "linux"
         when /darwin/
@@ -140,7 +167,7 @@ def os
       end
 
       def cpu
-        case ruby_config.fetch('host_cpu')
+        case ruby_config.fetch("host_cpu")
         when /arm.*64/
           "arm64"
         when /64/

shopify-cli.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   end
   spec.bindir = "bin"
   spec.require_paths = ["lib", "vendor"]
-  spec.extensions = ["ext/shopify-cli/extconf.rb"]
+  spec.extensions = ["ext/shopify-cli/extconf.rb", "ext/shopify-extensions/extconf.rb"]
   # Do NOT include `shopify` as a listed executable via `spec.executables`.
   # `ext/shopify-cli/extconf.rb` will dynamically create a script and soft-link
   # `/usr/local/bin/shopify` to that script, in order to "lock" the Ruby used to