Move us closer to the Shopify style guide

[DazWorrall]

I needed a change of pace so decided to do some style gardening :)

Our rubocop config has drifted far from the style guide, this PR doesn't bring us all the way up to date but does knock out the quick wins. Our rubocop config is much smaller after this, and the _todo file is completely removed. There are still a few exclusions in the rubocop config I will work on in follow ups.

There only only a couple of substantive changes:

• Switch a use of JSON.load to JSON.parse (here)
• Check for frozen strings in OutputChunk 6fce3c0

That last one is required because write out string literals at the end of tasks, and these are now frozen:

shipit-engine/app/models/shipit/task.rb

Lines 274 to 277 in 7c5affc

	def report_dead!
	write("ERROR: Background job hasn't reported back in #{PRESENCE_CHECK_TIMEOUT} seconds.")
	error!
	end

Is there a cleaner fix?

[DazWorrall]

Oh and just for fun: adopting the style guide without making any changes gives us 1163 offenses detected 😁

[ayatsynych]

I didn't review every file 😛but I have checked locally with the robocop 👏

[casperisfine]

Our rubocop config has drifted far from the style guide

Well, it actually predates it significantly.

[casperisfine]

• There's a few places it broke the indentations
• Please disable Style/PerlBackrefs
• There's other cop I'd have a lot to say about, but if it makes it easier for the occasional Shopify contributor, then fine.

[wvanbergen]

Is there a cleaner fix?

You could also mark the literal that gets fed to this method as non-frozen: +"literal"

[DazWorrall]

You could also mark the literal that gets fed to this method as non-frozen: +"literal"

This was a good suggestion, but I decided against it because it turns out the test suite is also peppered with write calls.

[DazWorrall]

As for the PerlBackrefs cop I split the difference: added a match_info = foo.match pattern where that was an option, and where not reverted to $n usage and whitelisted it.

[casperisfine]

Thanks