Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeypatch deprecated omniauth-github behaviour #1012

Closed
wants to merge 1 commit into from

Conversation

DazWorrall
Copy link
Member

Fixes #1011

The issue is in omniauth-github but it is currently unmaintained, so this patches in the fix which is unlikely to be merged any time soon.

This patch has been installed successfully on other apps at Shopify.

@casperisfine
Copy link
Contributor

Quick update:

  • The unmaintained notice seem outdated: Update README.md omniauth/omniauth-github#85, so there's hope it will be fixed upstream some time soon.
  • In the meantime Shipit users can put gem 'omniauth-github', github: 'DazWorrall/omniauth-github', branch: 'query-auth-deprecated' in their Gemfile.
  • If the PR isn't merged in a few days / weeks, then we can consider other options.

@casperisfine
Copy link
Contributor

We managed to get the fix upstream and released.

Closing this

Ref: #1011

@casperisfine casperisfine deleted the patch-omniauth-github branch February 13, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of Github API with access_token query parameter is deprecated
2 participants