fix: support existing deprecated Rebalance.Strategy field usage #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napallday
reviewed
Sep 30, 2022
config.go
Outdated
| @@ -794,6 +794,12 @@ func (c *Config) Validate() error { | |||
| return ConfigurationError("ReadCommitted requires Version >= V0_11_0_0") | |||
| } | |||
|
|
|||
| // backward compatibility on Rebalance Strategy | |||
There was a problem hiding this comment.
The code works, but I'm not sure if it's good to modify the config in Validation method.
And btw there is no need to clear c.Consumer.Group.Rebalance.GroupStrategies here.
Because c.Consumer.Group.Rebalance.Strategy takes precedence of c.Consumer.Group.Rebalance.GroupStrategies in sarama (
https://github.com/Shopify/sarama/blob/v1.37.0/consumer_group.go#L443-L453 & https://github.com/Shopify/sarama/blob/v1.37.0/consumer_group.go#L333-L340)
There was a problem hiding this comment.
I agree with you. So just delete the case segment woud be enough. Keep no editing in Validation method.
dnwe
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2351