Enforce frozen_string_literal: true

[sambostock]

The default EnforcedStyle is always, which enforces that all files have a # frozen_string_literal comment, but doesn't care if it's true or false. always_true enforces true, which we want. Any existing files can simply be added to a TODO list or disable the cop.

[andyw8]

I think this is problematic because we override SafeAutoCorrect to be true.

If you have a file such as:

# frozen_string_literal: false

a = "x"
a << "y"

and run rubocop -a (i.e. 'safe' autocorrect), it will change false to true which will result in a runtime error.

[sambostock]

Hmmm... wouldn't that be fine, since the developer would have to triage it in their PR anyway? I think if we have that false, then the dev would have to manually add the comment, rather than the something like VS Code adding it automatically.

[sambostock]

Arguably, it was always possible to write that file without a comment, and run the autocorrect which would default to frozen_string_literal: true I believe, which would be the same problem. The only difference being that modifying it on existing files could break production code, but it would go through PR review, so should be caught.

[andyw8]

Ok, yeah, it's probably not a big deal, just feels a little off to label it as safe when it's not.

[sambostock]

Yeah, I agree. I tracked down the PR that originally made that change though, and it looks like it's intentional.