Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare required_ruby_version 2.7 and run CI against Ruby 2.7 - 3.1, and minimum Rubocop version #389

Merged
merged 3 commits into from May 13, 2022

Conversation

sambostock
Copy link
Contributor

The last time the config was updated (#386), we missed that we were adding a dependency on a more recent version of Rubocop than the one declared as minimum in the gemspec, as mentioned in #388 (comment).

To address this, and prevent it from happening again, the following changes are made:

  • the minimum rubocop version is bumped accordingly
  • in addition to the version in Gemfile.lock, CI now also runs against the version of rubocop declared to be the minimum

This more recent version also drops support for Ruby 2.5 and made me realize we should be testing against multiple Ruby versions, so the following other changes are made:

  • required_ruby_version is declared in gemspec
    • 2.7 was chosen as it is the oldest version not at end-of-life
  • CI now runs against Rubies 2.7, 3.0, and 3.1
    • a test is added to ensure this list always includes the required_ruby_version

This was missed when the config was last updated.
Also, a test is added to ensure we always test against the required_ruby_version.
@rafaelfranca rafaelfranca merged commit 0ad0cdb into main May 13, 2022
@rafaelfranca rafaelfranca deleted the version-stuff branch May 13, 2022 14:58
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 13, 2022 19:59 Inactive
@volmer
Copy link
Contributor

volmer commented Jul 19, 2022

Sorry I'm late to this but if we always want to use the minimum required version of RuboCop specified on the gemspec for testing then why don't we just declare it directly on the Gemfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants