Use Layout/BeginEndAlignment style start_of_line

[dylanahsmith]

Problem

Currently we disable the Layout/RescueEnsureAlignment in Shopify Core and have a TODO to re-enable it. There used to be a comment saying to renable it when rubocop/rubocop#6433 was fixed but it didn't get renabled after that, I assume because it doesn't have the desired effect.

For instance, it autocorrects with changes like this

       host = begin
         URI.parse(value).host
-      rescue URI::Error
-        nil
+             rescue URI::Error
+               nil
       end

which is pretty close to the original issue reported in that issue, with the difference being the presence of the begin keyword.

Solution

Using the Layout/BeginEndAlignment style of start_of_line avoids the above problem and uses a style that seems consistent with our existing coding style. This style is used by the Layout/RescueEnsureAlignment cop when it is enabled.

If this is too disruptive a change to introduce without a major release, the alternative would be to disable the Layout/RescueEnsureAlignment cop since it doesn't have the desired behaviour without Layout/BeginEndAlignment also enabled.

[dylanahsmith]

cc @Edouard-chin since you have context on rubocop/rubocop#6433

[volmer]

Makes sense to me. Could you please include this rule in the README as well?

[Edouard-chin]

👍