Fix Rubocop 0.81.0 compatibility #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larouxn
changed the title
volmer
approved these changes
Apr 1, 2020
|
I suppose we'll need to release a v1.0.1 of this gem once this is merged. 🤔 |
|
Yes we will. Also given that RuboCop ships breaking changes in minor versions we should limit the range of the compatible version of RuboCop to allow automatic patch upgrades only (e.g. |
rafaelfranca
requested changes
Apr 1, 2020
larouxn
force-pushed
the
fix_rubocop_0.81.0_compatability
branch
3 times, most recently
from
fb33635
to
1770c92
Compare
|
Great points. I've updated the |
volmer
approved these changes
Apr 2, 2020
rafaelfranca
requested changes
Apr 2, 2020
larouxn
force-pushed
the
fix_rubocop_0.81.0_compatability
branch
from
1770c92
to
1b48316
Compare
rafaelfranca
approved these changes
Apr 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop v0.81.0 removed
Lint/EndInMethodin favour of consolidating withinStyle/EngBlock. (rubocop/rubocop#7813)Thus, I removed our
Lint/EndInMethodrule. We already haveStyle/EngBlockspecified here:ruby-style-guide/rubocop.yml
Lines 635 to 636 in b5e4bc9
Example failure using
rubocop-shopify-1.0.0: