Disable the Sorbet department by default #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we have ``` AllCops: DisabledByDefault: true ``` The option is not respected for custom cops. This leads to Sorbet cops being ran on repos that are not using Sorbet on Policial, because Policial loads the custom cops. This kind of sucks for local usage because it prints a warning about unknown department, but we can remove this once upstream fixes this issues.
|
cc @caynan |
bdewater
approved these changes
May 1, 2019
|
rubocop/rubocop#7013 patch submitted upstream. |
|
I'm going to merge this now, since I don't want people running into false alarms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we have
The option is not respected for custom cops. This leads to Sorbet cops being ran on repos that are not using Sorbet on Policial,
because Policial loads the custom cops.
This kind of sucks for local usage because it prints a warning about unknown department, but we can remove this once upstream
fixes this issues.