Skip config tests on minimum Rubocop version #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we want to ensure we're always compatible with the minimum Rubocop version we declare in our gemspec, the config checks are specific to the Rubocop version listed in Gemfile.lock. As such, we skip these tests when checking against the minimum Rubocop version. Rubocop is still invoked against the repository's own code during these runs, which allows us to catch incompatible config (e.g. cops only available in new versions, deprecated config keys).
rafaelfranca
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we want to ensure we're always compatible with the minimum Rubocop version we declare in our gemspec, the config checks are specific to the Rubocop version listed in
Gemfile.lockbecause different Rubocop versions have different default config.As such, we skip these tests when checking against the minimum Rubocop version.
Rubocop is still invoked against the repository's own code during these runs, which allows us to catch incompatible config (e.g. cops only available in new versions, deprecated config keys).