Merge pull request #391 from Shopify/fix-config-check-for-minimum-rub…

…ocop-version Skip config tests on minimum Rubocop version
Shopify · May 13, 2022 · f56d998 · f56d998
2 parents f5122f5 + 7175204
commit f56d998
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
@@ -28,3 +28,5 @@ jobs:
       run: bundle info rubocop | head -1
     - name: RuboCop and Tests
       run: bundle exec rake
+      env:
+        CHECKING_RUBOCOP_VERSION_COMPATIBILITY: ${{ matrix.gemfile == 'gemfiles/minimum_rubocop.gemfile' }}
diff --git a/test/config_test.rb b/test/config_test.rb
@@ -7,6 +7,8 @@
 
 class ConfigTest < Minitest::Test
   def test_config_is_unchanged
+    skip if checking_rubocop_version_compatibility?
+
     Rake.application.load_rakefile
 
     original_config = "test/fixtures/full_config.yml"
@@ -32,6 +34,8 @@ def test_config_is_unchanged
   end
 
   def test_config_has_no_redundant_entries
+    skip if checking_rubocop_version_compatibility?
+
     config = RuboCop::ConfigLoader.load_file("rubocop.yml")
     default_config = RuboCop::ConfigLoader.default_configuration
     redundant_config = Hash.new { |hash, key| hash[key] = {} }
@@ -57,4 +61,10 @@ def test_config_has_no_redundant_entries
 
     assert(redundant_config.empty?, error_message)
   end
+
+  private
+
+  def checking_rubocop_version_compatibility?
+    ENV.fetch("CHECKING_RUBOCOP_VERSION_COMPATIBILITY", "") == "true"
+  end
 end