Merge pull request #432 from Shopify/trailing-comma-args

Enable TrailingCommaInArguments
Shopify · Sep 5, 2022 · ab54c20 · ab54c20
2 parents 3dddb41 + 92a2650
commit ab54c20
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/rubocop.yml b/rubocop.yml
@@ -708,7 +708,7 @@ Style/TrailingBodyOnMethodDefinition:
   Enabled: false
 
 Style/TrailingCommaInArguments:
-  Enabled: false
+  EnforcedStyleForMultiline: consistent_comma
 
 Style/TrailingCommaInArrayLiteral:
   EnforcedStyleForMultiline: consistent_comma

diff --git a/test/config_test.rb b/test/config_test.rb
@@ -17,7 +17,7 @@ def test_config_is_unchanged
       Rake::Task["config:dump"].invoke(tempfile.path)
 
       diff = Diffy::Diff.new(
-        original_config, tempfile.path, source: "files", context: 5
+        original_config, tempfile.path, source: "files", context: 5,
       ).to_s
 
       error_message = <<~ERROR

diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml
@@ -3882,9 +3882,9 @@ Style/TrailingBodyOnModule:
 Style/TrailingCommaInArguments:
   Description: Checks for trailing comma in argument lists.
   StyleGuide: "#no-trailing-params-comma"
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.36'
-  EnforcedStyleForMultiline: no_comma
+  EnforcedStyleForMultiline: consistent_comma
   SupportedStylesForMultiline:
   - comma
   - consistent_comma