Merge pull request #373 from Shopify/remove-redundant

Remove redundant configuration keys

rubocop.yml

@@ -24,9 +24,6 @@ Layout/ArgumentAlignment:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-Layout/EmptyLineAfterGuardClause:
-  Enabled: true
-
 Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
@@ -370,9 +367,6 @@ Style/AndOr:
 Style/ArgumentsForwarding:
   Enabled: false
 
-Style/AsciiComments:
-  Enabled: false
-
 Style/BisectedAttrAccessor:
   Enabled: false
 
@@ -439,9 +433,6 @@ Style/EvalWithLocation:
 Style/ExpandPathArguments:
   Enabled: false
 
-Style/ExplicitBlockArgument:
-  Enabled: true
-
 Style/ExponentialNotation:
   Enabled: false
 
@@ -463,9 +454,6 @@ Style/FrozenStringLiteralComment:
     literals will become the default in a future Ruby version, and we want to make
     sure we''re ready.'
 
-Style/GlobalStdStream:
-  Enabled: true
-
 Style/GuardClause:
   Enabled: false
 

test/config_test.rb

@@ -30,4 +30,31 @@ def test_config_is_unchanged
       assert(diff.empty?, error_message)
     end
   end
+
+  def test_config_has_no_redundant_entries
+    config = RuboCop::ConfigLoader.load_file("rubocop.yml")
+    default_config = RuboCop::ConfigLoader.default_configuration
+    redundant_config = Hash.new { |hash, key| hash[key] = {} }
+
+    # This entry is not a cop.
+    config.delete("inherit_mode")
+
+    config.each do |cop_name, cop_config|
+      default_cop_config = default_config.fetch(cop_name)
+      cop_config.each do |key, value|
+        default_value = default_cop_config[key]
+        redundant_config[cop_name][key] = value if value == default_value
+      end
+    end
+
+    error_message = <<~ERROR
+      Error: The following config values are the same as the default Rubocop configuration:
+
+      #{redundant_config.to_yaml.delete_prefix("---\n")}
+
+      Please remove these entries from the configuration, as they are unnecessary.
+    ERROR
+
+    assert(redundant_config.empty?, error_message)
+  end
 end