Disable Style/MapIntoArray

While preferring `.map { ... }` vs `a = []; b.each { a << ... }` makes sense, this cop has lots of gotchas, so we'll probably have to evaluate it's false positive rate to determine if we should enable it or not.
Shopify · Apr 9, 2024 · 17cf184 · 17cf184
1 parent ac2a83e
commit 17cf184
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/rubocop.yml b/rubocop.yml
@@ -628,6 +628,11 @@ Style/MagicCommentFormat:
 Style/MapCompactWithConditionalBlock:
   Enabled: false
 
+<% if rubocop_version >= "1.63" %>
+Style/MapIntoArray:
+  Enabled: false
+<% end %>
+
 Style/MapToHash:
   Enabled: false
 

diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml
@@ -3229,7 +3229,7 @@ Style/MapIntoArray:
   Description: Checks for usages of `each` with `<<`, `push`, or `append` which can
     be replaced by `map`.
   StyleGuide: "#functional-code"
-  Enabled: pending
+  Enabled: false
   VersionAdded: '1.63'
   Safe: false
 Style/MapToHash: