Adjust Gemfile.lock platforms #410
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Dec 22, 2022
dirceu
approved these changes
Dec 22, 2022
paracycle
reviewed
Dec 22, 2022
| arm64-darwin-21 | ||
| arm64-darwin-22 | ||
| arm64-darwin | ||
| x86_64-darwin | ||
| x86_64-linux |
There was a problem hiding this comment.
Shouldn't we also add ruby as a platform?
vinistock
force-pushed
the
vs/adjust_locked_platforms
branch
from
2df19d3 to
50d00e4
Compare
st0012
approved these changes
Dec 22, 2022
st0012
force-pushed
the
vs/adjust_locked_platforms
branch
from
50d00e4 to
ec84b1d
Compare
|
I need this PR to test changes without patching Gemfile.lock locally, so merging now. |
st0012
added a commit
that referenced
this pull request
Jan 5, 2023
We're seeing similar issues described in this issue: dependabot/dependabot-core#5917 And it looks like most of the issues came from bundler, not dependabot itself. Given that - ruby-lsp is using a relatively old version of bundler (2.3.7 was released in Feb 2022) - dependabot now uses 2.3.25 by default I think it's worth trying out a new bundler to see if it helps resolving the problem. And if we compare this commit's change with #410, we can see that the new bundler already generates the entries we'd like to see. So I think the result is promising.
Merged
klaaspieter
pushed a commit
to klaaspieter/ruby-lsp
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the recent changes to fix CI, we now can't bundle install in our dev laptops. I'm hoping adding arm64-darwin, x86-darwin and x86-linux will fix the issue.