Fix the code action cache level #382
Merged
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to cache it at server, but that depends on which range we receive from the editor. What we need to use the cache for is for fetching the diagnostics, which does not change based on the range
egiurleo
approved these changes
Dec 9, 2022
st0012
approved these changes
Dec 12, 2022
|
Good call. Added a test for it in the latest commit. |
st0012
reviewed
Dec 12, 2022
|
|
||
| # If diagnostics is being properly cached, then we should only see the increment_counter block invoked once for the | ||
| # same URI, no matter how many times we invoke it and with which range | ||
| RubyLsp::Requests::Support::RuboCopDiagnosticsRunner.instance.stub(:run, increment_counter) do |
There was a problem hiding this comment.
TIL we can implement an increment counter like this.
There was a problem hiding this comment.
Minitest stubs accept either a value or a callable as the return value, so you can pass any lambdas to it. It's really convenient.
st0012
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While pairing on #381, I noticed that we had our
cache_fetchinvocation at the wrong place for code actions. We want to cache the diagnostics response, so that we don't have to run RuboCop more than once, but we do not want to cache the code actions response since it may change depending on which range is visible in the editor.Implementation
Removed the cache from the server part, which depends on the range, and wrapped the diagnostics call in the cache.