Skip node locating when the document is not parsed #343
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Although
DocumentHighlight#run
skips#visit
when the document is not parsed,DocumentHighlight#initialize
doesn't skip node locating.This means that
DocumentHighlight
will fail to initialize and cause error when the source code has syntax error.Fixes #326
Implementation
Check if the document is parsed before trying to find the target node from
document.tree
.Automated Tests
Added a test to make sure the
DocumentHighlight
request can still be initialized with syntax-incorrect source code.Manual Tests
OUTPUT
tabfoo
to triggerdocumentHighlight
requestsmain
, you'd see